bids-standard / bids-specification

Brain Imaging Data Structure (BIDS) Specification
https://bids-specification.readthedocs.io/
Creative Commons Attribution 4.0 International
267 stars 154 forks source link

[ENH] microelectrode electrophysiology specification (BEP032) #1705

Open yarikoptic opened 5 months ago

yarikoptic commented 5 months ago

Replaces https://github.com/bids-standard/bids-specification/pull/1352 submitted from a fork outside of bids-specification.

Add specification for microelectrode electrohpysiology datasets based on the BEP032 proposal

[!Note]

We meet regularly and everyone is welcome

Next meeting: insert date on URL to join

Communication channel: https://framalistes.org/sympa/info/neuroscience-data-structure

[!Tip]

HTML preview of this BEP


TODOs

Issues this PR would likely to address

Issues to see being addressed while working on this BEP (likely to move above) or not (moved below):

Other issues which relate but not in scope here and provided for reference/backreference

TheChymera commented 4 months ago

Also relevant if you'd like to comment. → https://docs.google.com/document/d/1oG-C8T-dWPqfVzL2W8HO3elWK8NIh2cOCPssRGv23n0/edit?disco=AAABIzHGpUU

TheChymera commented 4 months ago

Also I forgot to link to this when I wrote it → https://docs.google.com/document/d/1oG-C8T-dWPqfVzL2W8HO3elWK8NIh2cOCPssRGv23n0/edit?disco=AAABIGPAMOw

Remi-Gau commented 3 months ago

Random suggestion: maybe having a markdown file in the source tree and the mkdoc config so you can at least use a macro to render the filename template.

The HTML version of this could then be reviewed by people still working on the google doc: may help if you don't read BIDS schema yaml fluently.

Remi-Gau commented 3 months ago

Did a few minor fix to pacify pre-commit and make sure the HTML page rendered.

Also check the top message of this PR: https://github.com/bids-standard/bids-specification/pull/1705#issue-2134603705

I added some github admonitions that need tweaking so people know where this BEP is discussed.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.92%. Comparing base (1cb92eb) to head (73012b3). Report is 36 commits behind head on master.

:exclamation: Current head 73012b3 differs from pull request most recent head a46e439

Please upload reports for the commit a46e439 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1705 +/- ## ========================================== + Coverage 87.79% 87.92% +0.13% ========================================== Files 16 16 Lines 1360 1375 +15 ========================================== + Hits 1194 1209 +15 Misses 166 166 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.