Closed Remi-Gau closed 4 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.93%. Comparing base (
c9e4779
) to head (f9e699b
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@tsalo @sappelhoff @effigies This is a draft but as far as I can tell this would allow using admonitions without breaking the PDF build.
Can you have a quick look and tell me if you see something I am missing?
the remark linting will be annoying though
an easy fix
OK so it seems that remark-lint-code-block-style is set to fenced
by remark-preset-lint-markdown-style-guide
So need to find how to unset that.
This looks awesome!
PDF looks fine to me.
Note that some links are not rendered in the pdf but this is not related to this PR.
For example the link at the top of the genetic section:
[`UK biobank`](https://github.com/bids-standard/bids-examples/tree/master/genetics_ukbb)
I think this is because of the back tick in the square brackets.
For contributors: should we preface our admonitions with some markdown comments the way we do it the macros so that users are not confused about what they are ?
I don't think that's necessary. Macros aren't exactly common, but admonitions are. We can have that info in a style guide if we want though.
I don't think that's necessary. Macros aren't exactly common, but admonitions are. We can have that info in a style guide if we want though.
OK so something to add in the contributing.md
Actually before merging.