search

bids-standard / bids-specification

Brain Imaging Data Structure (BIDS) Specification
https://bids-specification.readthedocs.io/
Creative Commons Attribution 4.0 International
265 stars 154 forks source link

BEP-038: Atlases #1714

Open effigies opened 4 months ago

effigies commented 4 months ago

This PR proposes the inclusion of BEP-038 into the BIDS specification.

The BEP is hosted on its own branch in the main repository, and BEP leads have been given write permissions to the branch. If you are a BEP lead and having issues writing to the branch, please let a maintainer know and we can make sure you have access.

At present this is a starting point, and I anticipate significant rewriting and reorganization before final merge. There is extensive discussion in #1281 that needs to be turned into concrete proposals. I would suggest keeping the discussion on this PR minimal so that newcomers can follow the thread. When opening PRs against this branch, please include a reference to this PR (#1714) so that it shows up in the thread.

Rendered draft

https://bids-specification--1714.org.readthedocs.build/en/1714/

Related discussions

CPernet commented 3 months ago

@erdalkaraca @tsalo this has passed the review period now, can this be checked and merged? thx

oesteban commented 3 months ago

I'm working on a review. Please hold on.

effigies commented 3 months ago

I also have not finished my review/proposed changes. I am unlikely to get to it before the meeting next week as I am traveling for another meeting this week.

effigies commented 3 months ago

This BEP currently needs:

1) Schema implementation of required checks and filename rules 2) Examples implementing all significant (ideally all) features proposed to https://github.com/bids-standard/bids-examples 3) Implementation of all rules in https://github.com/bids-standard/bids-validator and tested on the examples. 4) A two week public review period announced on all communication channels.

I'm converting this to draft to reflect this status. I'm going to temporarily restrict comments, pending synchronous discussion.

francopestilli commented 2 months ago

Hi, Folks,

Thanks for helping with this BEP. It was great to see several of you at OHB<

I would like to kindly ask to go back to this BEP and make a decision before OHBM. We have a few proposals to pick from (see here), most of them would be fine with @PeerHerholz and myself.

What are the pending issues that would need to be resolved?

@effigies @CPernet @oesteban @PeerHerholz @melanieganz @sappelhoff @christinerogers @tsalo @erdalkaraca @jdkent