bids-standard / bids-specification

Brain Imaging Data Structure (BIDS) Specification
https://bids-specification.readthedocs.io/
Creative Commons Attribution 4.0 International
265 stars 154 forks source link

FIX: Improve detection of admonition end, fixing unrendered links in PDF #1738

Closed Remi-Gau closed 3 months ago

Remi-Gau commented 3 months ago
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.93%. Comparing base (28eb790) to head (feb5357).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1738 +/- ## ======================================= Coverage 87.93% 87.93% ======================================= Files 16 16 Lines 1351 1351 ======================================= Hits 1188 1188 Misses 163 163 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Remi-Gau commented 3 months ago

OK seems fixed

will clean up

Remi-Gau commented 3 months ago

things look good now

image

effigies commented 3 months ago

Is that a normal amount of white space? Is it worth collapsing more than two newlines down to two?

Remi-Gau commented 3 months ago

Is that a normal amount of white space? Is it worth collapsing more than two newlines down to two?

Do you mean below the white space below the Genetic Descriptor heading?

effigies commented 3 months ago

Yes.

Remi-Gau commented 3 months ago

pretty sure it has nothing to do with this PR:

see the PDF of our latest release

https://github.com/bids-standard/bids-specification-pdf-releases/blob/main/bids-spec.pdf

Remi-Gau commented 3 months ago

if you say that we should make that gap a tad smaller in another PR, then you have my sword and my bow and my axe.

effigies commented 3 months ago

No worries. Just noticing that your test had some extra newlines and making sure that they aren't causing visual artifacts.