search

bids-standard / bids-specification

Brain Imaging Data Structure (BIDS) Specification
https://bids-specification.readthedocs.io/
Creative Commons Attribution 4.0 International
265 stars 154 forks source link

SCHEMA: Allow surrounding whitespace in integers #1742

Closed effigies closed 3 months ago

effigies commented 3 months ago

Discovered thanks to @ericearl's magical database. Some people generated TSVs that space-pad their numerical columns. Actual tools don't have a problem interpreting these numbers (pandas, deno, Python), just our regular expressions that we use to validate the columns as strings.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.93%. Comparing base (4c642bd) to head (32825ff).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1742 +/- ## ======================================= Coverage 87.93% 87.93% ======================================= Files 16 16 Lines 1351 1351 ======================================= Hits 1188 1188 Misses 163 163 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

effigies commented 3 months ago

@sappelhoff Would appreciate your thoughts here.

effigies commented 3 months ago

The example I saw was so that onsets <10 would line up with the onsets >=10.