search

bids-standard / bids-specification

Brain Imaging Data Structure (BIDS) Specification
https://bids-specification.readthedocs.io/
Creative Commons Attribution 4.0 International
265 stars 154 forks source link

[ENH] Use "Tag XXXX, YYYY" not "Tag (XXXX,YYYY)" for DICOM Tags #1758

Closed yarikoptic closed 2 months ago

yarikoptic commented 3 months ago

In general I like more (XXXX,YYYY) form but the other form more prevalent and thus what I also suggested in https://github.com/bids-standard/bids-specification/pull/1450/files

Attention to this was triggered by @CPernet 's comment in

src/schema/objects/metadata.yaml and src/schema/rules/checks/asl.yaml src/schema/rules/sidecars/mri.yaml all use form without () and pet sometimes only used with ()

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.93%. Comparing base (bd08602) to head (9027f38). Report is 39 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1758 +/- ## ======================================= Coverage 87.93% 87.93% ======================================= Files 16 16 Lines 1351 1351 ======================================= Hits 1188 1188 Misses 163 163 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yarikoptic commented 2 months ago

@bids-standard/maintainers ping on this trivial PR.

Remi-Gau commented 2 months ago

@tsalo @effigies forgot to mention this light PR to reveiw yesterday