bids-standard / bids-specification

Brain Imaging Data Structure (BIDS) Specification
https://bids-specification.readthedocs.io/
Creative Commons Attribution 4.0 International
274 stars 157 forks source link

[ENH] Allow to keep heading of admonition in PDF #1768

Open Remi-Gau opened 5 months ago

Remi-Gau commented 5 months ago
codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.93%. Comparing base (591eebb) to head (c9971d9). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1768 +/- ## ======================================= Coverage 87.93% 87.93% ======================================= Files 16 16 Lines 1351 1351 ======================================= Hits 1188 1188 Misses 163 163 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Remi-Gau commented 5 months ago

Should only affect the PDF.

image

image

effigies commented 5 months ago

I don't love how this looks, as the connection between the header and content isn't clear. Perhaps we could look into using existing pandoc tooling instead of hacking our own thing?

Remi-Gau commented 5 months ago

thanks for the pointers

will try if a simple div may do the work in better way