Closed yarikoptic closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 87.93%. Comparing base (
943c20e
) to head (ff1d55b
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I was wide off -- we did clarify modality definition in https://bids-specification.readthedocs.io/en/stable/common-principles.html#definitions and for better or for worse it was Ok and no need to bring in "contrast" here... I will adjust now
edit: nah -- better just close ;)
_acq
is also used in other modalities so description should be generic._mod-
change relates to a discussion of _mod destiny inhttps://github.com/bids-standard/bids-2-devel/issues/70
and to accent that it is not really "modality" term (e.g.
mri
,eeg
, ...) we use generally through out BIDS specification.Some might argue about use of "contrast" to describe
T1w
etc but we do use "contrast" to that extent in other places already AFAIK.