bids-standard / bids-specification

Brain Imaging Data Structure (BIDS) Specification
https://bids-specification.readthedocs.io/
Creative Commons Attribution 4.0 International
264 stars 154 forks source link

[ENH] use full width entity page #1784

Closed Remi-Gau closed 2 months ago

Remi-Gau commented 2 months ago

closes none

Tiny tweak that helps for all tables but that of MRI.

Before

image

https://bids-specification.readthedocs.io/en/latest/appendices/entity-table.html#biopotential-amplification-eeg-and-ieeg

After

image

https://bids-specification--1784.org.readthedocs.build/en/1784/appendices/entity-table.html

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.93%. Comparing base (943c20e) to head (df804cb). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1784 +/- ## ======================================= Coverage 87.93% 87.93% ======================================= Files 16 16 Lines 1351 1351 ======================================= Hits 1188 1188 Misses 163 163 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

effigies commented 2 months ago

Definitely an improvement, but losing navigation doesn't seem great. Maybe just hide the TOC?

Once https://github.com/squidfunk/mkdocs-material/issues/3428 exists, we could see about starting navigation in collapsed mode.

Remi-Gau commented 2 months ago

Definitely an improvement, but losing navigation doesn't seem great. Maybe just hide the TOC?

Let me try.

effigies commented 2 months ago

Updated original comment with new screenshot.

@tsalo Would you mind being a second pair of eyes?