BEP032: ephys -> {icephys, ecephys}

bids-standard / bids-specification

Brain Imaging Data Structure (BIDS) Specification

https://bids-specification.readthedocs.io/

Creative Commons Attribution 4.0 International

274 stars 157 forks source link

BEP032: ephys -> {icephys, ecephys} #1806

Closed yarikoptic closed 3 months ago

yarikoptic commented 5 months ago

Implements

https://github.com/bids-standard/bids-specification/issues/1800 .

Didn't want to push to bep032 since not yet agreed upon by @bids-standard/bep032 but wanted to be ready when/if we decide to proceed.

Closes #1800

TheChymera commented 5 months ago

Looks good to me.

TheChymera commented 5 months ago

Pending of course potential updates from the discussion.

effigies commented 4 months ago

@yarikoptic Do you intend to fix this up according to https://github.com/bids-standard/bids-specification/issues/1800#issuecomment-2112715341 or should we close this?

yarikoptic commented 4 months ago

let me fix it up to reflect #1800 ... will do now

yarikoptic commented 4 months ago

microelectrodes -> microelectrode

I might actually keep it plural and then make "cells" for intracel as well since there could be multiple electrodes/cells. Or why do you think it should become singular?

yarikoptic commented 4 months ago

I would also ask everyone to suggest using github suggestions mechanism, see e.g https://stackoverflow.com/questions/54239733/how-can-i-manually-add-suggestions-in-code-reviews-on-github on howto. Can even span multiple lines

VisLab commented 4 months ago

It was grammar - "Electrophysiological data from an extracellular microelectrodes" -- the an is problematic if plural.

yarikoptic commented 4 months ago

It was grammar - "Electrophysiological data from an extracellular microelectrodes" -- the an is problematic if plural.

ah, indeed! codespell guru fell into a trap ;-) I made two suggestions, see if I didn't screw up more: https://github.com/bids-standard/bids-specification/pull/1806/files#r1625124867

yarikoptic commented 3 months ago

FWIW -- pre-commit and check_links whining are not on changes in this PR

yarikoptic commented 3 months ago

ok, thanks everyone who participated -- let's proceed by merging into bep032 branch to avoid possible conflicts with other works. I will squash