search

bids-standard / bids-specification

Brain Imaging Data Structure (BIDS) Specification
https://bids-specification.readthedocs.io/
Creative Commons Attribution 4.0 International
264 stars 154 forks source link

Update circleci docker image #1832

Closed sappelhoff closed 1 month ago

sappelhoff commented 1 month ago

as per: https://support.circleci.com/hc/en-us/articles/23614965074459-2024-Image-Deprecations-and-Brownouts-Android-Linux-VM-Remote-Docker-Linux-VM

see: https://discuss.circleci.com/t/remote-docker-image-deprecations-and-eol-for-2024/50176

We will not see in the CI here whether or not this works, but only once we create a "merge commit" and let the CI run on master.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.04%. Comparing base (2d7cfd0) to head (9629ab0).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1832 +/- ## ======================================= Coverage 88.04% 88.04% ======================================= Files 16 16 Lines 1380 1380 ======================================= Hits 1215 1215 Misses 165 165 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sappelhoff commented 1 month ago

The CI did fail, albeit at a step prior to the one I introduced changes for here: https://app.circleci.com/pipelines/github/bids-standard/bids-specification/7492/workflows/064d2593-2005-45ae-8c23-f32cdf846a41/jobs/22350