bids-standard / bids-specification

Brain Imaging Data Structure (BIDS) Specification
https://bids-specification.readthedocs.io/
Creative Commons Attribution 4.0 International
264 stars 154 forks source link

Fix generation of BIDS changelog #1835

Closed sappelhoff closed 1 month ago

sappelhoff commented 1 month ago

Note that these issues seem to have been present for months already, and we didn't catch them, unfortunately.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.04%. Comparing base (40af25c) to head (91bc3f9).

:exclamation: Current head 91bc3f9 differs from pull request most recent head df40ab8

Please upload reports for the commit df40ab8 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1835 +/- ## ======================================= Coverage 88.04% 88.04% ======================================= Files 16 16 Lines 1380 1380 ======================================= Hits 1215 1215 Misses 165 165 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sappelhoff commented 1 month ago

getting confusing issues here.

Perhaps it's time we updated github-changelog-generator to a newer version ... not the one from X years, as currently.

So far we were blocked from doing that because of this issue:

... however, I think we can just ignore the base parameter, and do the attachment of our old, manual changelog ourselves with a few lines (1?) of code.

sappelhoff commented 1 month ago

it's really frustrating dealing with github tokens, there are too many, and none seem to work

I cannot find our CHANGE_TOKEN "secret" anywhere either. Anyone knows where it was generated?

sappelhoff commented 1 month ago

replacing this PR with https://github.com/bids-standard/bids-specification/pull/1836