search

bids-standard / bids-specification

Brain Imaging Data Structure (BIDS) Specification
https://bids-specification.readthedocs.io/
Creative Commons Attribution 4.0 International
264 stars 154 forks source link

Fix generation of BIDS changelog #1836

Closed sappelhoff closed 1 month ago

sappelhoff commented 1 month ago

Replaces #1835, so that this is a PR not from a fork, but from the org itself.

This is an attempt to work around the "Pass secrets to builds from forked pull requests" CircleCI setting, which we'd rather leave "switched off" for security reasons.

EDIT: will migrate this to GH actions, as discussed in maintainers meeting.

NOTE: authentification is working, but we run into secondary API limits, so the workflow may take a long time to run!

... mentioned in #1844

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.04%. Comparing base (124ac21) to head (2eb872e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1836 +/- ## ======================================= Coverage 88.04% 88.04% ======================================= Files 16 16 Lines 1380 1380 ======================================= Hits 1215 1215 Misses 165 165 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sappelhoff commented 1 month ago

Okay, I am confident that this PR now fixes our changelog situation. I have tested the last stage (after a merge commit) also in https://github.com/sappelhoff/testing and everything runs as expected.

All in all, this PR:

  1. moves the changelog generation from circleci to GH actions
  2. updates the changelog generation software to a newer version
  3. fixes the ensuing bugs that were previously uncaught

with this in place, we should have time to tackle a migration of the changelog generation as discussed in:

... without stressing over it.