search

bids-standard / bids-specification

Brain Imaging Data Structure (BIDS) Specification
https://bids-specification.readthedocs.io/
Creative Commons Attribution 4.0 International
264 stars 154 forks source link

[SCHEMA] Make electrodes.tsv REQUIRED for iEEG #1854

Open sappelhoff opened 3 weeks ago

sappelhoff commented 3 weeks ago

As discussed in the issue above ☝️, the electrodes.tsv file should be made REQUIRED for the iEEG modality. If it is impossible for a researcher to supply electrode coordinates (which would be saved in electrodes.tsv), then they may fill the cells with n/a.

effigies commented 3 weeks ago

I suppose that the logic here ultimately boils down to "every _ieeg.* data file MUST have an associated electrodes.tsv", but is this a transitive case, where _ieeg.* files need an associated _channels.tsv and each iEEG _channels.tsv file needs an associated _electrodes.tsv? Is it possible to have a common channels.tsv inherited but electrodes.tsv be subject-specific?

effigies commented 3 weeks ago

In any event, this will require adding electrodes to the context.associations object:

https://github.com/bids-standard/bids-specification/blob/eba3e08e2dbfd3ad2e57c2a52c3bda8c1961dc6c/src/schema/meta/context.yaml#L117-L222

Then the rule would simply be type(associations.electrodes) != "null". If we want to make rules about the contents of electrodes, those will need to go further and define specific contents of electrodes.