Closed effigies closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 88.06%. Comparing base (
0e506f0
) to head (c0915eb
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@dorahermes @VisLab WDYT?
Just noting that if a _task-
entity is allowed for an _coordsystem.json
it should also be allowed for an _electrodes.tsv
.
Good catch. task, acquisition and run were all permitted in the legacy validator for both electrodes.tsv and coordsystem.json, and all six combinations exist on OpenNeuro. For consistency, I've updated this PR to treat these all the same.
We've run into a situation where the regular validator regular expressions were written more laxly than the specification, leading to datasets that use entities that are against the spec but perfectly interpretable. In particular, the
task
entity has been permitted forcoordsystem.json
across EEG, iEEG, MEG and NIRS.Following the pattern established in #1722, instead of marking these datasets invalid with a schema-based validator, we relax the spec but add warnings.
cc @bids-standard/raw-electrophys and @rob-luke @lpollonini (we should make a NIRS team...).