search

bids-standard / bids-specification

Brain Imaging Data Structure (BIDS) Specification
https://bids-specification.readthedocs.io/
Creative Commons Attribution 4.0 International
274 stars 157 forks source link

[FIX] Update text to reflect that BackgroundSuppressionPulseTime is recommended #1891

Closed michaelf500 closed 1 month ago

michaelf500 commented 1 month ago

regarding Issue: Background suppression timing for ASL #1842

I've changed 'required' to 'recommended' and slightly reworded the sentence.

Michael

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.22%. Comparing base (0de4c9c) to head (61f3ed3). Report is 35 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1891 +/- ## ======================================= Coverage 88.22% 88.22% ======================================= Files 16 16 Lines 1393 1393 ======================================= Hits 1229 1229 Misses 164 164 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

tsalo commented 1 month ago

We have two approvals and it's been 5 days (not that the 5-day embargo is required for small bug fixes like this). I'm going to merge now.