search

bids-standard / bids-specification

Brain Imaging Data Structure (BIDS) Specification
https://bids-specification.readthedocs.io/
Creative Commons Attribution 4.0 International
279 stars 163 forks source link

[FIX] Define a metadata table for TB1EPI #1912

Closed effigies closed 2 months ago

effigies commented 2 months ago

This PR resolves #1351 by drawing the TotalReadoutTime and MixingTime definitions from the schema. I followed the table in https://bids-specification.readthedocs.io/en/latest/appendices/qmri.html#field-maps to determine the required metadata.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.23%. Comparing base (d6803bf) to head (a73c1b0). Report is 4 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1912 +/- ## ======================================= Coverage 87.23% 87.23% ======================================= Files 16 16 Lines 1410 1410 ======================================= Hits 1230 1230 Misses 180 180 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

effigies commented 2 months ago

Before

image

After

image

agahkarakuzu commented 2 months ago

@effigies it looks good to me as well. It aligns with fmriprep definitions, which also documents issues around Phillips. Maybe providing a hyperlink would make it clearer: https://fmriprep.org/en/1.0.0/sdc.html