search

bids-standard / bids-specification

Brain Imaging Data Structure (BIDS) Specification
https://bids-specification.readthedocs.io/
Creative Commons Attribution 4.0 International
279 stars 163 forks source link

fix(schema): Update microscopy pixel size checks to account for error and OME convention #1920

Closed effigies closed 2 months ago

effigies commented 2 months ago

@Remi-Gau's fix of our typo'd metadata field revealed an error in the PixelSizeInconsistent check. The main error is that OME-XML uses µm instead of um. I went ahead and also permitted some error to account for inconsistent serialization/floating point error.

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.23%. Comparing base (3c8a5aa) to head (10b320a). Report is 2 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1920 +/- ## ======================================= Coverage 87.23% 87.23% ======================================= Files 16 16 Lines 1410 1410 ======================================= Hits 1230 1230 Misses 180 180 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.