bids-standard / bids-specification

Brain Imaging Data Structure (BIDS) Specification
https://bids-specification.readthedocs.io/
Creative Commons Attribution 4.0 International
280 stars 165 forks source link

BEP030: Extend BIDS to add near-infrared spectroscopy (NIRS) #438

Closed rob-luke closed 2 years ago

rob-luke commented 4 years ago

I would like to propose extending BIDS to include near-infrared spectroscopy (NIRS) .

I have taken a look at the currently-active BEPs and could not see anything NIRS related. Is there already support for NIRS? And if not, is there sufficient interest for me to start a proposal?

sappelhoff commented 4 years ago

Thanks for opening the issue Robert. I think NIRS support in BIDS would be great. There is already a similar initivative in the NIRS community: https://github.com/fNIRS/snirf

I am not sure in how far BIDS and SNIRF are parallel or whether they could be joined.

It'd be great to discuss this with the NIRS community and SNIRF developers!

rob-luke commented 4 years ago

Thanks Stefan, I was unaware of SNIRF. It seems very well specified.

lpollonini commented 4 years ago

Coincidentally, my collaborative group has been discussing this for the last few weeks, so I definitely second Robert's proposal and will be interested in actively participating. If it may help, I am familiar with the SNIRF format and I am involved with the proposing SfNIRS (Society for Functional Near Infrared Spectroscopy). Please let me know the next steps, thanks!

rob-luke commented 4 years ago

Thats great news @lpollonini. There is a BIDS extension proposal guide, and a BIDS extension template. I am happy to make a start on the proposal document and put it online for us to edit/comment (I will post link in this thread). And in the meantime I will try and get a few more people interested. @lpollonini is this plan ok with you?

@sappelhoff is this the usual way to proceed? Whats the simplest/cleanest BEP that you would recommend I take a look at to get started?

lpollonini commented 4 years ago

Sounds good to me, Robert. I will wait for Stefan to educate us on the process (or anything we are missing), and then we can start coordinating the effort.

sappelhoff commented 4 years ago

Hi @rob-luke and @lpollonini, indeed what you suggest sounds like a good workflow. Let me add to that:

  1. as a starting point, please read the governance document (it's not too long), specifically the parts relating to a BIDS Extension Proposal (BEP)
  2. use the two documents you linked for more guidance
  3. get as many people interested as possible, forming a core team and a team of people to review regularly and provide opinions

In addition, I think it'd also be cool to start this off with a short call, where everybody can explain their backgrounds / motivations, and ask open questions that are not easily addressed in our docs. I would leave organizing that call to you (we could find a suitable date via email, and then post the decision here for more interested people to join).

As current example BEPs I recommend:

@franklin-feingold @effigies did I forget some crucial hints?

robertoostenveld commented 4 years ago

Hi @rob-luke and others

Last week we were meant to have a relatively small fNIRS toolkit course at the Donders, similar to these https://www.ru.nl/donders/agenda/donders-tool-kits/. This would be the first fNIRS toolkit for us, but we might make it into a yearly event. However, given the current situation the fNIRS toolkit has been postponed for now.

In this fNIRS toolkit course, I was to present on precisely BIDS and NIRS. I have just posted my slides online, see The Brain Imaging Data Structure and its use for fNIRS. I had planned to discuss how BIDS relates to SNIRF (which I consider perfectly compatible) and to propose "BEP028"(?) as BIDS for NIRS.

robertoostenveld commented 4 years ago

From my perspective related to this are https://github.com/fieldtrip/fieldtrip/issues/1161, https://github.com/fieldtrip/fieldtrip/blob/master/data2bids.m (which includes some preliminary NIRS support) and documentations and examples that we have at http://www.fieldtriptoolbox.org/example/bids/ (no NIRS example yet, but that could be added). With @helenacockx we just finished the first draft fNIRS dataset in BIDS format.

rob-luke commented 4 years ago

Hi @robertoostenveld,

It seems this issue came at a good time for all of us then. I am definitely on the same page as the slides you linked. How do you feel about the plan that Stefan proposed? Should I try and organise a call via email for the people in this thread? And in the meantime we see who else is interested. Or are you much further along this process?

robertoostenveld commented 4 years ago

Yes, please follow the plan that @sappelhoff outlined. I.e. get multiple people with different backgrounds (i.e. different labs/systems, but also acquainted with different softwares) involved, and get them to converge using a google doc.

lpollonini commented 4 years ago

I agree on everything, and will start reach out to people who may be interested in joining in. How long we should give ourselves to form ideas and schedule the introductory call? Would 10-14 days be acceptable considering the current situation (people doing lots of online teaching./mentoring, dissertation defenses coming up, etc.)? Maybe sooner? Thanks!

robertoostenveld commented 4 years ago

Planning it within 2 weeks sounds acceptable to me. Also, people that might miss out on the first online meeting should be able to join the process later. The first meeting would be more on setting goals and agreeing on a style of working, than on tossing arguments around and deciding.

lpollonini commented 4 years ago

Shall we try April 9th or 10th? No time is truly ideal with participants from all over the world, , but 7am US CDT / 2pm Europe / 10pm Syndey (+- 1 hour) seems manageable. What do you all think?

robertoostenveld commented 4 years ago

April 9 works for me, April 10 is Good Friday, which for me (and I suspect a lot of people) is a day off. Although week and weekend-days are now more similar while working at home, I think we should respect holidays if possible.

lpollonini commented 4 years ago

I agree, and I apologize. Good Friday was not marked on my calendar. April 9th is good for me.

sappelhoff commented 4 years ago

9th of April 2pm Berlin time sounds good to me :+1:

lpollonini commented 4 years ago

Is there a preferred meeting platform that BEP people have been using successfully? I would like to share this thread with the fNIRS community at large (500+ SfNIRS members and 1,300 on the Facebook group) and even if a small fraction will participate, we want to make sure the e-meeting remains manageable.

rob-luke commented 4 years ago

9th of April is good for me too.

I have created a zoom call that anyone can join with details below (no account required by attendees). But happy to use another platform if people prefer. I am also happy to take minutes for the meeting / record the session.

Time: Apr 9, 2020 10:00 PM Australia/Melbourne 
Join from a PC, Mac, iPad, iPhone or Android device: 
    Please click this URL to start or join: https://macquarie.zoom.us/j/338374702

Join from dial-in phone line: 
    Dial: +61 2 8015 2088
    Meeting ID: 338 374 702 
    International numbers available: https://macquarie.zoom.us/u/acPY47YGNU 

Join from a H.323/SIP room system: 
    Dial: 61262227588
    or SIP:7588@aarnet.edu.au
    or H323: 338 374 702@182.255.112.21  (From Cisco)
    or H323:182.255.112.21## 338 374 702  (From LifeSize or Polycom)
    or 162.255.36.11 or 162.255.37.11 

    Meeting ID: 338 374 702
rob-luke commented 4 years ago

@hamishib you may be interested in this.

hamishib commented 4 years ago

Great initiative @rob-luke, I will join the Zoom and see if I can contribute :)

robertoostenveld commented 4 years ago

As I am always confused with time zone differences (and even more so around daylight savings time changes), I scheduled it on arewemeetingyet to shows the meeting in everyones own timezone.

sappelhoff commented 4 years ago

hehe. Good call @robertoostenveld it seems that @rob-luke scheduled the meeting for a different time than @lpollonini proposed in https://github.com/bids-standard/bids-specification/issues/438#issuecomment-606000873

the arewemeetingyet link tells me that we meet at 10:00 (am!) UTC + 10 ... which would be 22:00 in Berlin ... would still be borderline okay with me. But just a heads up that this might be a confusion.

robertoostenveld commented 4 years ago

hmm, the confusion apparently is not yet gone. This is what I see Screenshot 2020-03-31 at 10 53 02 which is 14:00 in Central Europe Time. That works for me.

rob-luke commented 4 years ago

which is 14:00 in Central Europe Time

Isn't that what was proposed above? The call is scheduled for 10pm Aus time, which I checked was 2pm EU and 7am Houston. How did you get 10am Berlin time?

sappelhoff commented 4 years ago

okay, I just misread the output :man_shrugging: I was confused by the time underneath the "For your calendar" heading.

So everything is fine, sorry :-)

rob-luke commented 4 years ago

Ok cool. But I am open to other suggestions too. Taking calls at odd hours comes with the territory when you live upside down.

rob-luke commented 4 years ago

@robquant this might be of interest to you too.

robquant commented 4 years ago

@rob-luke Thanks for the hint!

rob-luke commented 4 years ago

It was nice to meet everyone on the call.

I can create the draft google doc based on the BIDS spec template tomorrow and email around a link. Did anyone record who put there hands up to be in the smaller committee? If we gather those emails I can set the write access permissions. Then we can also discuss a preferred method of communication.

lpollonini commented 4 years ago

Thanks Robert, I just started an e-mail thread...

manipulative commented 4 years ago

waiting for good news from you guys!

lpollonini commented 4 years ago

Hello @manipulative, we have formed a core working group as a result of the initial meeting and we'll be posting he a link to the BEP draft (as soon as ready) for anyone to comment on.

manipulative commented 4 years ago

Hi @lpollonini , I do some hyperscanning researches by fNIRS. Thanks for your contribution to bids of fnirs!

robertoostenveld commented 4 years ago

Hi @lpollonini is there already a google doc online with a draft that I (and others) can read and/or contribute our ideas to?

rob-luke commented 4 years ago

Yes. We have a google doc. I can open access and post here tomorrow when I get to my work pc.

rob-luke commented 4 years ago

Unless one of the others with access does it before then

robertoostenveld commented 4 years ago

I propose to share it such that others (i.e. people that do not explicitly have permissions) can only make suggestions. That ensures that the BEP leads keep in charge of all the edits and are aware of all changes to the actual text.

manipulative commented 4 years ago

Also want to view and comment it too

rob-luke commented 4 years ago

The document can be found here.

I have set the access to public with only ability to add comments (I think, see figure below). If anyone has issues accessing please comment in this thread and we can address it.

image

sappelhoff commented 4 years ago

This BEP is now official: BEP030, see: https://github.com/bids-standard/bids-website/pull/123

rob-luke commented 4 years ago

The BEP has had some attention lately. I will now create an example dataset according to the current specification.

Now would be a good time to collect some edits/reviews/comments on the document if anyone is available or can share the link... https://bids.neuroimaging.io/bep030

I am particularly interested to gather comments from users of different NIRS types and vendors than I have experience with (e.g. frequency domain NIRS devices).

rob-luke commented 3 years ago

Brief update: