bids-standard / bids-specification

Brain Imaging Data Structure (BIDS) Specification
https://bids-specification.readthedocs.io/
Creative Commons Attribution 4.0 International
279 stars 164 forks source link

BEP022 numbering conflict for Spectroscopy BEP #89

Closed yarikoptic closed 5 years ago

yarikoptic commented 6 years ago

BIDS Extension Proposal 22 (BEP022): Magnetic Resonance Spectroscopy (MRS) was announced awhile back by Dickson Wong (couldn't find github handle). I thought to add it to the registry of existing BEPs within this repo but found that BEP022 was already taken for "PET Preprocessing derivatives". Conflict was already identified by Roeland Hancock and confirmed by @filo but not reported here.

Hboni commented 6 years ago

Oh I didn't saw this BEP. When I was asked to add BIDS Extension Proposal (BEP): Computed tomography scan (CT), I found also that a BIDS Extension Proposal 22(BEP022): PET Preprocessing Derivatives was created so I added it, without checking the existence of others BEP. It's possible to change BEP number for BEP022 and BEP023 to add MRS as BEP022.

chrisgorgo commented 6 years ago

Sounds good to me - I sent an update to the PET Preprocessing Derivatives google doc changing it to 23. Could you send another PR adding MRS under 23 and changing PET derivatives to 22? Thanks!

Hboni commented 6 years ago

I think you mean PR adding MRS under 22 and changing PET derivatives to 23 and Computed Tomography to 24 ?

chrisgorgo commented 6 years ago

Yes

On Tue, Nov 20, 2018, 8:53 AM Hboni <notifications@github.com wrote:

I think you mean PR adding MRS under 22 and changing PET derivatives to 23 and Computed Tomography to 24 ?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/bids-standard/bids-specification/issues/89#issuecomment-440346088, or mute the thread https://github.com/notifications/unsubscribe-auth/AAOkp_zWwqai4firJFbnmIRMWtQjr5Seks5uxDOggaJpZM4YpOWl .

Hboni commented 5 years ago

Can be closed ?