Throw warning for columns of beh.tsv with no data_dictionary

Remi-Gau commented 3 years ago

As far as I can tell columns in _beh.tsv with no associated data dictionary in a json will not raise a warning with the validator.

It would probably be preferable for this behavior to be consistent with that for event.tsv

Point raised in this PR.

https://github.com/bids-standard/bids-validator/pull/1367#issue-1029095653

Remi-Gau commented 2 months ago

Still an issue with the deno bids-validator (v1.14.7-dev.0-249-g93ca7a02)

effigies commented 2 months ago

Okay, I think there are two problems:

1) We don't warn on missing column definitions for TSV files that allow additional columns. 2) We don't actually have a schema rule for behavioral files. Let's make one. Should we have some pre-defined ones that are okay to leave out of a dictionary? e.g.,

Behavioral:
  selectors:
    - suffix == "beh"
  columns:
    trial_type: optional
    response_time: optional
    HED: optional
    stim_file: optional
  additional_columns: allowed

We could also set columns: {} if everything should be defined.

bids-standard / bids-validator

Throw warning for columns of beh.tsv with no data_dictionary #1376