search

bids-standard / bids-validator

Validator for the Brain Imaging Data Structure
https://bids-standard.github.io/bids-validator/
MIT License
178 stars 107 forks source link

version reporting in compiled/installed version from url is just "master" or "alpha" #1994

Open yarikoptic opened 3 weeks ago

yarikoptic commented 3 weeks ago

I don't know if there is any reasonable solution here, may be somehow possible to install from git exported archive which could do some subs for strings and provide some idea of a version?

❯ deno compile -o /tmp/bids-validator-deno -A https://raw.githubusercontent.com/bids-standard/bids-validator/master/bids-validator/src/bids-validator.ts
...
❯ /tmp/bids-validator-deno --version
bids-validator master

even from a tag it is kinda not so good

❯ deno compile -o /tmp/bids-validator-deno -A https://raw.githubusercontent.com/bids-standard/bids-validator/v1.14.7-dev.0/bids-validator/src/bids-validator.ts
Check https://raw.githubusercontent.com/bids-standard/bids-validator/v1.14.7-dev.0/bids-validator/src/bids-validator.ts
Compile https://raw.githubusercontent.com/bids-standard/bids-validator/v1.14.7-dev.0/bids-validator/src/bids-validator.ts to /tmp/bids-validator-deno
Archive:  /home/yoh/.tmp/.tmpAIaseK/denort.zip
  inflating: denort                  
❯ /tmp/bids-validator-deno --version
bids-validator alpha
❯ deno compile -o /tmp/bids-validator-deno -A https://raw.githubusercontent.com/bids-standard/bids-validator/v1.14.6/bids-validator/src/bids-validator.ts
Check https://raw.githubusercontent.com/bids-standard/bids-validator/v1.14.6/bids-validator/src/bids-validator.ts
Compile https://raw.githubusercontent.com/bids-standard/bids-validator/v1.14.6/bids-validator/src/bids-validator.ts to /tmp/bids-validator-deno
Archive:  /home/yoh/.tmp/.tmphvjo7J/denort.zip
  inflating: denort                  
❯ /tmp/bids-validator-deno --version
bids-validator alpha

It looks good if I compile from a local clone:

❯ deno compile -o /tmp/bids-validator-deno -A bids-validator/bids-validator/src/bids-validator.ts
Check file:///tmp/bids-validator/bids-validator/src/bids-validator.ts
Compile file:///tmp/bids-validator/bids-validator/src/bids-validator.ts to /tmp/bids-validator-deno
Archive:  /home/yoh/.tmp/.tmp928ec7/denort.zip
  inflating: denort                  
deno compile -o /tmp/bids-validator-deno -A   7.97s user 0.49s system 220% cpu 3.842 total
❯ /tmp/bids-validator-deno --version
bids-validator v1.14.7-dev.0-62-gbd302130
effigies commented 3 weeks ago

We haven't yet released since adding in version information, so the version on deno.land still says alpha. deno.land only hosts tags, it's not just a copy of the repository.

There's not much to do if you build directly from a git branch. It will tell you the $REF that you entered because all it has to go on is a URL.