search

bids-standard / bids-validator

Validator for the Brain Imaging Data Structure
https://bids-standard.github.io/bids-validator/
MIT License
181 stars 109 forks source link

Unclear which file in "You should define 'HEDVersion' for this file." #2122

Open yarikoptic opened 3 weeks ago

yarikoptic commented 3 weeks ago 
> datalad containers-run -n bids-validator $PWD

        8: [WARN] You should define 'HEDVersion' for this file. If you don't provide this information, the HED validation will use the latest version available. (code: 109 - HED_VERSION_NOT_DEFINED)

        Please visit https://neurostars.org/search?q=HED_VERSION_NOT_DEFINED for existing conversations about this issue.

whenever we have

(deno) yoh@typhon:/mnt/DATA/data/yoh/1076_spacetop$ grep HEDVersion dataset_description.json
  "HEDVersion": "8.2.0",

(deno) yoh@typhon:/mnt/DATA/data/yoh/1076_spacetop$ grep bids-vali .datalad/config 
[datalad "containers.bids-validator"]
        image = code/containers/images/bids/bids-validator--1.14.11.sing

so we have HEDVersion in dataset_description.json but there is still that Warning and not clear which file it is actually talking about

VisLab commented 3 weeks ago

@rwblair @nellh This is the deno version for the validator. I believe we are relying on BIDS to pass us this information now since we are doing by-file validation rather than taking in the entire dataset. Can you please check and advise?

P.S. HED no longer uses the latest version available, but requires an actual version. The message:

the HED validation will use the latest version available. (code: 109 - HED_VERSION_NOT_DEFINED)

does not appear in the hed-validator.

yarikoptic commented 3 weeks ago

@rwblair @nellh This is the deno version for the validator.

FWIW, I think this is still an original node version, which we run out of distributed container. Yet to get to try deno version