search

bids-standard / bids-validator

Validator for the Brain Imaging Data Structure
https://bids-standard.github.io/bids-validator/
MIT License
1 stars 4 forks source link

Permit bidsignored files in scans.tsv #48

Open effigies opened 3 years ago

effigies commented 3 years ago

There are unstandardized files that might nevertheless be appropriate to put in a scans.tsv. By putting them in .bidsignore, we get [ERR] The filename in scans.tsv file does not match what is present in the BIDS dataset. (code: 129 - SCANS_FILENAME_NOT_MATCH_DATASET), and thus have to ignore scans.tsv as well.

xref bids-standard/legacy-validator#971 bids-standard/legacy-validator#976 bids-standard/bids-validator#70

appukuttan-shailesh commented 8 months ago

Facing the same problem. I am willing to have a go at implementing this if it is approved that we can ignore files in scans.tsv that correspond to filters in .bidsignore

effigies commented 8 months ago

I suppose it's a question of how ignored files are treated. If they are simply dropped, then yes, doing a match of scans.tsv files against ignore entries is probably the best we can easily do.

If we have a list of ignored files, then I think it would be good to check whether the entry is in that list, as we can then still error on absent files.

effigies commented 1 week ago

This may be done. Adding a test case should resolve it.