Change output filename & ScreenResolution return values

bids-standard / eye2bids

Convert eyetracking data to a BIDS compatible format (BEP20)

MIT License

6 stars 6 forks source link

Change output filename & ScreenResolution return values #34

Closed julia-pfarr closed 1 year ago

julia-pfarr commented 1 year ago

output filenames: according to issue #24: output file has now the prefix of the edf file. If edf file already contains "_eyetrack" suffix, it is not written again.
ScreenResolution threw an error because it expected integers but it returned strings --> changed to integers

julia-pfarr commented 1 year ago

Included code to extract eyetrack.tsv from samples_asc

@Remi-Gau like I already said in the BIDS chat group, the tests are failing and and the output_dir is not considered when I run eye2bids in the terminal (i.e., I define --output_dir but my output is saved in my input_file directory anyway). I don't know why this is, apparently I changed something that caused this. But I don't think I can find out what it is

Remi-Gau commented 1 year ago

side note: tests were already failing in #33 so I will probably start fixing things in main and then get back to this PR.

julia-pfarr commented 1 year ago

side note: tests were already failing in #33 so I will probably start fixing things in main and then get back to this PR.

Yes but that was due to a different thing which I fixed with this PR (it was ScreeResolution expected int and got str, which I fixed in this PR. Now it's a different error)

Remi-Gau commented 1 year ago

@julia-pfarr Can you check that the data is saved in the appropriate folder?

julia-pfarr commented 1 year ago

@julia-pfarr Can you check that the data is saved in the appropriate folder?

yes, data is saved in the appropriate folder