search

bids-standard / eye2bids

Convert eyetracking data to a BIDS compatible format (BEP20)
MIT License
5 stars 5 forks source link

eye2bids classifying StartTime and StopTime metadata as arrays rather than numbers [BUG] #96

Open dlevitas opened 3 weeks ago

dlevitas commented 3 weeks ago

eye2bids (version 0.1.dev84+gf49a08f) injects the StartTime and StopTime metadata fields as arrays rather than numbers, which appear to be improper (e.g. here).

cc @julia-pfarr @Remi-Gau

Remi-Gau commented 3 weeks ago

Ok I suspect that the start and stop of each "trial" should logged in the physioevents rather than the Metadata of the physio eyetracking.

julia-pfarr commented 3 weeks ago

Ok I suspect that the start and stop of each "trial" should logged in the physioevents rather than the Metadata of the physio eyetracking.

It is currently listed as metadata for the _recording-

But yes, starts and stops of each trial are logged in the physioevents but this is not what Dan means, I think, but the recorded Start and Stop Time in the physio.json are the ones corresponding to one run.

@dlevitas I will fix it, this is a residual from the time when we still allowed multiple Start/StopTimes in the metadata and we put them in an array. However, now that we only allow one it should be a number.

julia-pfarr commented 2 weeks ago

PR #98