search

bids-standard / legacy-validator

Validator for the Brain Imaging Data Structure
https://bids-standard.github.io/legacy-validator/
MIT License
186 stars 111 forks source link

(deno) TSV type check overhaul. #1987

Closed rwblair closed 5 months ago

rwblair commented 5 months ago

Modify tsv column value type checks to use user defined types if specifiedified in sidecar and schema rules for that column are in the 'json schema' defined style outlined in bids-standard/bids-specification#1838

For traditional schema defined columns, if they're required the type check produces an error, but if it is not required it generates a warning.

I ran deno fmt on the files and its got opinions on quotes and semicolons, thats where most the changes come from.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.68%. Comparing base (5b7a364) to head (0e036b5).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1987 +/- ## ======================================= Coverage 85.68% 85.68% ======================================= Files 91 91 Lines 3792 3792 Branches 1220 1220 ======================================= Hits 3249 3249 Misses 457 457 Partials 86 86 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

effigies commented 5 months ago

Fixed the CI failures. Back to green on Ubuntu!