search

bids-standard / legacy-validator

Validator for the Brain Imaging Data Structure
https://bids-standard.github.io/legacy-validator/
MIT License
186 stars 111 forks source link

fix(tests): Remove assumptions about tmpfile location, clean up #1988

Closed effigies closed 5 months ago

effigies commented 5 months ago

OSX tests are failing because we assume temporary files exist in /tmp, while OSX has different defaults. This creates a temporary file and splits the returned path to ensure we can point to existing files.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.11%. Comparing base (aa76b84) to head (09e46d6).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1988 +/- ## ========================================== + Coverage 85.68% 87.11% +1.43% ========================================== Files 91 130 +39 Lines 3792 6304 +2512 Branches 1220 1520 +300 ========================================== + Hits 3249 5492 +2243 - Misses 457 721 +264 - Partials 86 91 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

effigies commented 5 months ago

Closed in favor of #1989.