bids-standard / legacy-validator

Validator for the Brain Imaging Data Structure
https://bids-standard.github.io/legacy-validator/
MIT License
186 stars 111 forks source link

fix: Small cleanups from recent test fixes #1992

Closed effigies closed 5 months ago

effigies commented 5 months ago

Was meaning to get these in before #1989 was merged, but nbd. I saw on https://deno.land/std@0.224.0/path/mod.ts?s=posix that path.posix is deprecated. Also, the Windows fixes made me want to go back and clean up the changes I made for OSX. The use of an explicit /tmp seems like it's asking for trouble, and if we create a temporary directory, things simplify a bit.

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.04%. Comparing base (07cbca5) to head (56bada5).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1992 +/- ## ========================================== + Coverage 85.68% 87.04% +1.36% ========================================== Files 91 131 +40 Lines 3792 6306 +2514 Branches 1220 1520 +300 ========================================== + Hits 3249 5489 +2240 - Misses 457 726 +269 - Partials 86 91 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.