search

bids-standard / legacy-validator

Validator for the Brain Imaging Data Structure
https://bids-standard.github.io/legacy-validator/
MIT License
186 stars 111 forks source link

Completely rewrite HED support #2014

Closed happy5214 closed 4 months ago

happy5214 commented 4 months ago

This commit completely rewrites the HED integration module to only build most objects when necessary (due to memory issues).

This depends on code in hed-validator that has not yet been released to npm, and thus it currently does not build. Please test using the modify-bids-interface branch of hed-validator and npm link.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 86.11111% with 5 lines in your changes missing coverage. Please review.

Project coverage is 86.77%. Comparing base (53fdba6) to head (b2024d9). Report is 2 commits behind head on master.

Files Patch % Lines
bids-validator/validators/hed.js 85.71% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2014 +/- ## ========================================== + Coverage 85.68% 86.77% +1.09% ========================================== Files 91 132 +41 Lines 3792 6346 +2554 Branches 1220 1522 +302 ========================================== + Hits 3249 5507 +2258 - Misses 457 748 +291 - Partials 86 91 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

effigies commented 4 months ago

The ieeg_epilepsy_ecog example is failing, presumably because it has "HEDVersion": "n/a" in its dataset_description.json. Will open a PR to remove that, unless you'd rather it stay?

VisLab commented 4 months ago

Yes, it should be removed. If a dataset_description.json has a HedVersion field, it must be a valid HED version or it is considered to be an error. Thx!