search

bids-standard / legacy-validator

Validator for the Brain Imaging Data Structure
https://bids-standard.github.io/legacy-validator/
MIT License
186 stars 111 forks source link

Improve test coverage for code added in #2014 #2018

Closed happy5214 closed 4 months ago

happy5214 commented 4 months ago

Per a request from @VisLab, this PR adds test coverage to the three lines listed in https://github.com/bids-standard/bids-validator/pull/2014/files/aeee4c1cfd0c3ea5eced14c6b99f69abc89260df..b2024d91d7efb0a1cc183d8f4d1afb4e9fcb94a7 as not having test coverage. This is a follow-on from #2014.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.85%. Comparing base (a8f02f7) to head (c057f90).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2018 +/- ## ========================================== + Coverage 85.60% 86.85% +1.24% ========================================== Files 91 132 +41 Lines 3785 6350 +2565 Branches 1218 1523 +305 ========================================== + Hits 3240 5515 +2275 - Misses 459 744 +285 - Partials 86 91 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

happy5214 commented 4 months ago

hed.js now has complete test coverage.

effigies commented 4 months ago

LGTM, but I'll leave to @rwblair to make a final review and merge.