search

bids-standard / legacy-validator

Validator for the Brain Imaging Data Structure
https://bids-standard.github.io/legacy-validator/
MIT License
186 stars 111 forks source link

feat(json): Warn on missing RECOMMENDED metadata #2027

Closed effigies closed 4 months ago

effigies commented 4 months ago

This dramatically increases the number of warnings emitted, since BIDS has been very liberal with its RECOMMENDATIONS.

The alternative is to go add issues to all of the sidecar fields that previously warned.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.35%. Comparing base (56734ab) to head (297c2e8).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2027 +/- ## ========================================== + Coverage 85.75% 87.35% +1.59% ========================================== Files 91 132 +41 Lines 3785 6325 +2540 Branches 1218 1526 +308 ========================================== + Hits 3246 5525 +2279 - Misses 453 709 +256 - Partials 86 91 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rwblair commented 4 months ago

People seem to ignore warnings as is, but not reporting them is against the spirit of BIDS. I'm neutral either way.