bids-standard / legacy-validator

Validator for the Brain Imaging Data Structure
https://bids-standard.github.io/legacy-validator/
MIT License
186 stars 111 forks source link

rf(context): Refactor inheritance principle to walk from leaf to root #2035

Closed effigies closed 4 months ago

effigies commented 4 months ago

This PR proposes a single implementation of the inheritance principle.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 88.23529% with 8 lines in your changes missing coverage. Please review.

Project coverage is 87.09%. Comparing base (f4de42a) to head (8f682d0). Report is 2 commits behind head on master.

Files Patch % Lines
bids-validator/src/files/inheritance.ts 81.57% 7 Missing :warning:
bids-validator/src/schema/context.ts 87.50% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2035 +/- ## ========================================== + Coverage 85.75% 87.09% +1.33% ========================================== Files 91 134 +43 Lines 3785 6402 +2617 Branches 1218 1543 +325 ========================================== + Hits 3246 5576 +2330 - Misses 453 736 +283 - Partials 86 90 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.