Closed effigies closed 4 months ago
Attention: Patch coverage is 88.23529%
with 8 lines
in your changes missing coverage. Please review.
Project coverage is 87.09%. Comparing base (
f4de42a
) to head (8f682d0
). Report is 2 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
bids-validator/src/files/inheritance.ts | 81.57% | 7 Missing :warning: |
bids-validator/src/schema/context.ts | 87.50% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR proposes a single implementation of the inheritance principle.
.parent
reference to aFileTree
instance. For the moment it was simplest to treat it as optional, because the browser implementation constructs theBIDSFile
objects before the containingFileTree
objects.src/files/inheritance.ts
exposes awalkBack
generator function that finds at most one matching file in each level. Ifinherit = False
, it only looks at the leaf level.