Closed effigies closed 3 months ago
Attention: Patch coverage is 90.00000%
with 6 lines
in your changes missing coverage. Please review.
Project coverage is 87.25%. Comparing base (
a4e1a09
) to head (73c52d1
).
Files | Patch % | Lines |
---|---|---|
...ds-validator/src/validators/internal/unusedFile.ts | 82.85% | 6 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This implements the legacy checks:
The approach is to add a
.viewed
boolean field onBIDSFile
and trip it when either of the inheritance principlewalkBack()
or the expression languageexists()
functions finds the file.Note that apparently we had a lot of false negatives in the legacy validator, and SIDECAR_WITHOUT_DATAFILE is causing failures of examples.
Should wait on #2064, #2066 and https://github.com/bids-standard/bids-examples/pull/461.
Diff specific to this PR: https://github.com/bids-standard/bids-validator/compare/2ecf188...e5aeeca