bids-standard / legacy-validator

Validator for the Brain Imaging Data Structure
https://bids-standard.github.io/legacy-validator/
MIT License
186 stars 111 forks source link

v1.14.7 npm package broken on bids-examples #2059

Closed effigies closed 3 months ago

effigies commented 3 months ago

The stable tests on the examples repo are failing:

https://github.com/bids-standard/bids-examples/actions/runs/10259615491/job/28384370437?pr=461

The master tests have not failed at all, before or after the release. It seems to be something related to what gets pushed to npm.

The errors are HED-related:

Validating dataset asl001/: Running  bids-validator asl001 -c /home/runner/work/bids-examples/bids-examples/bidsconfig.json --ignoreNiftiHeaders
bids-validator@1.14.7
    1: [ERR] An internal error occurred during HED validation. (code: 106 - HED_INTERNAL_ERROR)

        Summary:                Available Tasks:        Available Modalities: 
        8 Files, 94.63KB                                MRI                   
        1 - Subject                                                           
        1 - Session                                                           

    If you have any questions, please post on https://neurostars.org/tags/bids.

cc @happy5214

sappelhoff commented 3 months ago

We see the exact same issue at https://github.com/mne-tools/mne-bids

cc-ing @VisLab, too

VisLab commented 3 months ago

I was going to running the bids-validator on my local machine to test the issue with the more comprehensive error messages that @happy5214 just pushed up to the hed-validator.

However, when I looked at the newly installed npm bids-validator node-modules there was no @hedvalidator in it. When I tried to link to my local copy of the hed-validator this is verified by the following message:

bids-validator> npm link hed-javascript npm error code E404 npm error 404 Not Found - GET https://registry.npmjs.org/hed-javascript - Not found npm error 404 npm error 404 'hed-javascript@*' is not in this registry.

I can do an npm install hed-validator with no problem so I think this problem might be in the bids-validator release on npm? @rwblair @nellh

effigies commented 3 months ago

@VisLab Should that be npm link hed-validator, not hed-javascript?

rwblair commented 3 months ago

Published a new release, v1.14.8 @VisLab @sappelhoff let me know if this new version fixes the issue.

1.14.7 did have a version of the hed validator bundled in its pack, but hedValidator.bids.buildBidsSchema hedValidator.bids.buildBidsSchemas was undefined. I'm still not sure what went wrong in the build or pack step to cause it.

happy5214 commented 3 months ago

1.14.7 did have a version of the hed validator bundled in its pack, but hedValidator.bids.buildBidsSchema was undefined. I'm still not sure what went wrong in the build or pack step to cause it.

I hope that function name is a typo in your post. It should be hedValidator.bids.buildBidsSchemas (i.e. more than one schema).

rwblair commented 3 months ago

@happy5214 It was, sorry about that.

effigies commented 3 months ago

Fixed in 1.14.8: https://github.com/bids-standard/bids-examples/actions/runs/10259615491/job/28415516112

sappelhoff commented 3 months ago

let me know if this new version fixes the issue.

it did, thanks a lot!