search

bids-standard / legacy-validator

Validator for the Brain Imaging Data Structure
https://bids-standard.github.io/legacy-validator/
MIT License
186 stars 111 forks source link

fix(json): Validate all JSON fields #2075

Closed effigies closed 3 months ago

effigies commented 3 months ago

The JSON validation code strongly assumed it was validating sidecars, not JSON files. These changes streamline the logic a bit to ensure that sidecars and JSON files are treated the same, but the sidecar "origin" code is skipped for JSON files.

Closes #2007.

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 87.17949% with 5 lines in your changes missing coverage. Please review.

Project coverage is 87.23%. Comparing base (ec73f3a) to head (4a2218b).

Files Patch % Lines
bids-validator/src/schema/applyRules.ts 87.17% 3 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2075 +/- ## ========================================== + Coverage 85.69% 87.23% +1.53% ========================================== Files 91 139 +48 Lines 3782 6800 +3018 Branches 1220 1607 +387 ========================================== + Hits 3241 5932 +2691 - Misses 455 776 +321 - Partials 86 92 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.