bids-standard / legacy-validator

Validator for the Brain Imaging Data Structure
https://bids-standard.github.io/legacy-validator/
MIT License
186 stars 111 forks source link

chore: Various cleanups #2085

Closed effigies closed 3 months ago

effigies commented 3 months ago

Keeping it short and sweet. Okay, I threw a few in here. Started playing around with https://knip.dev to see if it could detect and remove dead types (it can't). Looks like eslint might be able to, but I didn't really try to get that working. Started playing with deno lint, and it can do a couple fixes. Was able to write an awk script to fix prefer-const.

One thing I noticed was we have a function to ask for environment variable permissions, but we don't use it because Deno.env.get() does it for us. I realized we could reduce the need for that check for FORCE_COLOR in interactive cases by switching the order of the short-circuit.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.60%. Comparing base (1f1d945) to head (fa325da). Report is 7 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2085 +/- ## ========================================== + Coverage 85.69% 87.60% +1.90% ========================================== Files 91 130 +39 Lines 3782 6807 +3025 Branches 1220 1615 +395 ========================================== + Hits 3241 5963 +2722 - Misses 455 752 +297 - Partials 86 92 +6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.