bids-standard / legacy-validator

Validator for the Brain Imaging Data Structure
https://bids-standard.github.io/bids-validator/
MIT License
185 stars 111 forks source link

.bidsignore format #2146

Closed tamjidimtiaz closed 4 weeks ago

tamjidimtiaz commented 1 month ago

Hi, my bids directory contains some files that are not compatible with the current bids format which are following:

image

I want to include thase files in the .bidsignore. I created the .bidsignore file and include the following:

image

However it didn't work while I was validating again through bids-validator. Can someone give me some guidelines?

effigies commented 1 month ago

I'd get rid of the **/. That's not needed to match, and might not be implemented by the matching library.

tamjidimtiaz commented 1 month ago

I did that as well. But did not work. Do you have any other suggestions?

effigies commented 1 month ago

Could you show a full (text, not screenshot) listing of your dataset, the .bidsignore and the validator output (this could be screenshot, if there's no good way to format the text)?

tamjidimtiaz commented 1 month ago

Is it okay if I share the screenshot of the tree output of the listing of the dataset?

tamjidimtiaz commented 1 month ago

bidstext.txt

effigies commented 1 month ago

Okay, looking at that, you have derivatives directories inside your subject directories, which is likely to be a significant problem. You also use space-<label> in your anatomical filenames, which is not permitted.

What are the validator outputs?

tamjidimtiaz commented 1 month ago

Validator output:

Image

CPernet commented 4 weeks ago

I have the same issue -- the old validator works but the new one does not like the .bidsignore

effigies commented 4 weeks ago

Hmm. Could you print out the bytes?

python -c "with open('.bidsignore', 'rb') as fobj: print(fobj.read(50))"

I wonder if you have \r characters that are not being stripped.

effigies commented 4 weeks ago

Also, can you verify that this occurs with the CLI validator?

deno run --reload -A jsr:@bids/validator $DATASET
effigies commented 4 weeks ago

Nevermind. Found the bug: #2151

CPernet commented 4 weeks ago

You guys are too fast ... Thx 🙏