search

bids-standard / legacy-validator

Validator for the Brain Imaging Data Structure
https://bids-standard.github.io/bids-validator/
MIT License
185 stars 111 forks source link

feat: Pass hedCode as subcode to group errors #2149

Closed effigies closed 3 weeks ago

effigies commented 1 month ago

cc @happy5214 In case you have any other suggestions.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 87.55%. Comparing base (0a2530b) to head (e118e49). Report is 20 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #2149 +/- ## ========================================== + Coverage 85.73% 87.55% +1.82% ========================================== Files 91 133 +42 Lines 3785 7008 +3223 Branches 1220 1657 +437 ========================================== + Hits 3245 6136 +2891 - Misses 454 777 +323 - Partials 86 95 +9 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

happy5214 commented 1 month ago

Is subcode currently a valid parameter, and will it be added if it isn't?

effigies commented 1 month ago

It is:

https://github.com/bids-standard/bids-validator/blob/f85d51f2b710be07137e6147388ed71461c369f5/bids-validator/src/types/issues.ts#L8-L19

Note this is for the schema validator, which has a new issue format.