Closed rwblair closed 3 weeks ago
Attention: Patch coverage is 69.69697%
with 10 lines
in your changes missing coverage. Please review.
Project coverage is 87.66%. Comparing base (
ae54efa
) to head (ae52740
). Report is 12 commits behind head on master.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Should we just prune sourcedata/
and code/
in the same way we do derivatives, except unconditionally?
Another approach could be to adapt:
To:
- if (dsContext.isPseudoFile(dir)) {
+ if (dsContext.isPseudoFile(dir) && !ignore.test(dir.path)) {
yield new BIDSContext(pseudoFile(dir), dsContext)
} else {
We would need to expose the ignore
object somewhere outside the BIDSFile
s to make this work, but maybe that's better than the current approach, where we inject a singleton and then update it before we lose its reference.
Yeah I'm not a fan of how ignore is being managed right now. I'll play with loading bidsignore earlier and storing in the dataset context like other configuration options.
Should a bidsignore file in a root dataset apply to nested datasets?
Should a bidsignore file in a root dataset apply to nested datasets?
I don't think so.
This latest commit fails, cli and web, on ds001583, which has its .bidsignore as a directory instead of a file. Guess I'll make it survive any error but log/warn on non NOENT errors. ds001583 is only dataset I've found with a .bidsignore as a directory.
Certain directories get contexts during calls to walk, ignore test needs to be run and set before then. Noticed certain directories in sourcedata of ds004720 triggering NOT_INCLUDED errors.
I still need to write tests for this.
Fixes https://github.com/bids-standard/bids-validator/issues/2127.