search

bids-standard / legacy-validator

Validator for the Brain Imaging Data Structure
https://bids-standard.github.io/legacy-validator/
MIT License
186 stars 111 forks source link

Incorrect warnings: TaskName key in channels.tsv, and events.tsv missing for noise #2154

Closed Moo-Marc closed 1 month ago

Moo-Marc commented 1 month ago

I get this error for MEG *_channels.tsv files: warning: SIDECAR_KEY_RECOMMENDED (TaskName) But that's clearly wrong for channel lists, and it's not in the specification.

There's another warning that could be improved. Currently, it warns of missing events.tsv file, but recognizes "rest" tasks as not needing it. Another task that doesn't need events is an empty room noise recording, "noise". The validator should check that word too and prevent this warning.

Cheers

effigies commented 1 month ago

The emptyroom problem was also noted in https://github.com/bids-standard/bids-validator/issues/2137 and should be resolved by the latest development version.

Added a fix for this to bids-standard/bids-specification#1941

Moo-Marc commented 1 month ago

@effigies @rwblair As I commented in bids-standard/bids-validator#12 (but I forgot to tag anyone so it was probably missed), noise recordings may be inside "normal" subject folders instead of sub-emptyroom, so that fix doesn't work in general. I believe checking task-noise is the way to go.

effigies commented 1 month ago

Actually, reopening bids-standard/bids-validator#12 instead of this one, since it's more focused on this one problem.