Closed effigies closed 1 month ago
Attention: Patch coverage is 77.77778%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 87.48%. Comparing base (
f40d4de
) to head (525163b
). Report is 3 commits behind head on master.
Files with missing lines | Patch % | Lines |
---|---|---|
bids-validator/src/validators/bids.ts | 71.42% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Before:
After:
We previously used "Microscopy", but we looked up the value from
schema.rules.modalities
, so that would fail. We could map the display names, but I don't think it will hurt anybody to usemicr
. We also weren't supporting motion.This won't help with patched schemas introducing new modalities, but blacklisting a modality introduced by a patch seems like an extremely niche use case. It would be nice if we could get the suggested values without actually limiting, as there's no harm in blacklisting something that doesn't exist. But the main use case would be OpenNeuro blacklisting a modality, and we skip over argument parsing and call
validate()
directly.This PR adds a check so that tools calling via the API will warn, not crash, if passing an unknown modality.