search

bids-standard / pybids

Python tools for querying and manipulating BIDS datasets.
https://bids-standard.github.io/pybids/
MIT License
225 stars 122 forks source link

dwi sbref, dwi entities, and TB1* top-level json missing in pybids config. #1058

Closed bpinsard closed 6 months ago

bpinsard commented 6 months ago

Currently, it seems that the config here does not allow dwi sbref, so build_path fails when datatype='dwi' and suffix='sbref' https://github.com/bids-standard/pybids/blob/master/bids/layout/config/bids.json while it is valid in the spec https://bids-specification.readthedocs.io/en/stable/modality-specific-files/magnetic-resonance-imaging-data.html#diffusion-imaging-data

bpinsard commented 6 months ago

In fact the dwi patterns in that config file are missing a bunch of entities from the spec above. Dumbish question: is there a way to know which spec version each pybids version tracks? my 9pm brain can't find it.

bpinsard commented 6 months ago

that file is missing a bunch of TB1* top-level json too.

Remi-Gau commented 6 months ago

The config does not follow a specific version of the spec as far as I can tell.

We usually update it when we discover blind spots (like you just did).

Top level jsons are the biggest blind spots I think.

Ideally we'd like to one day be able rely on the BIDS schema but in the mean time can you open a PR to update this?