search

bids-standard / pybids

Python tools for querying and manipulating BIDS datasets.
https://bids-standard.github.io/pybids/
MIT License
225 stars 122 forks source link

[MAINT] transfer test to bids validator #1081

Closed Remi-Gau closed 3 months ago

Remi-Gau commented 3 months ago

companion PR to https://github.com/bids-standard/python-validator/pull/8

there are more than 600 lines of test that are commented: should I bother transferring them to the other repo too?

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.72%. Comparing base (d66be75) to head (f286231). Report is 5 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1081 +/- ## ========================================== - Coverage 89.81% 89.72% -0.09% ========================================== Files 63 63 Lines 7174 7123 -51 Branches 1373 1363 -10 ========================================== - Hits 6443 6391 -52 - Misses 532 533 +1 Partials 199 199 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

effigies commented 3 months ago

there are more than 600 lines of test that are commented: should I bother transferring them to the other repo too?

The bad values might be worth it, just as assert not validator.is_bids(). The good values, I don't think so.

Remi-Gau commented 3 months ago

there are more than 600 lines of test that are commented: should I bother transferring them to the other repo too?

The bad values might be worth it, just as assert not validator.is_bids(). The good values, I don't think so.

OK I will try to transfer those then.

Remi-Gau commented 3 months ago

will merge #1080 before this one