search

bids-standard / pybids

Python tools for querying and manipulating BIDS datasets.
https://bids-standard.github.io/pybids/
MIT License
225 stars 122 forks source link

BUG: symlink dirs treated as files during indexing #1087

Closed cookpa closed 2 months ago

cookpa commented 2 months ago

Fixes #1086

effigies commented 2 months ago

Thanks. We have a bids_examples fixture:

https://github.com/bids-standard/pybids/blob/95c7aa942d982685a0f22daa3951b4ccc692bdd6/bids/conftest.py#L41-L52

I think you should be able to create a test using one of the example datasets (https://github.com/bids-standard/bids-examples) that demonstrates this error?

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.77%. Comparing base (95c7aa9) to head (6ecffc7). Report is 3 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1087 +/- ## ========================================== + Coverage 89.75% 89.77% +0.02% ========================================== Files 63 63 Lines 7123 7141 +18 Branches 1364 1367 +3 ========================================== + Hits 6393 6411 +18 Misses 531 531 Partials 199 199 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

effigies commented 2 months ago

Thanks!

effigies commented 2 months ago

@cookpa Would you like to be listed as a contributor in releases? https://github.com/bids-standard/pybids/blob/master/.zenodo.json

cookpa commented 2 months ago

Sure, thanks! I'll edit the file

effigies commented 2 months ago

Feel free to just paste your snippet here and I'll include it in the release process. (A PR is also fine if you're already in the middle of it.)