search

bids-standard / pybids

Python tools for querying and manipulating BIDS datasets.
https://bids-standard.github.io/pybids/
MIT License
221 stars 122 forks source link

analysis/transformations bug: Orthogonalize transformation doesn't work on sparse variables #190

Closed adelavega closed 6 years ago

adelavega commented 6 years ago

When orthogonalizing a sparse variable (speech on/off) w.r.t to another sparse variable (with same onsets/durations), the resulting variable was the same as the input. That is, the transformation did not seem to work, whereas it worked when the variables were forced to be dense.

tyarkoni commented 6 years ago

@adelavega, remind me, did we resolve this?

tyarkoni commented 6 years ago

I have a vague recollection this was a transient bug introduced by some change. There's a test for this that passes, so it should work fine...

adelavega commented 6 years ago

Sorry, but I have no clue. I can dig more if you want tomorrow.

tyarkoni commented 6 years ago

Well, tests pass, and one of them tests only using sparse variables, so I'm going to close this. Re-open if necessary.