Closed bieli closed 1 year ago
Solution to review https://github.com/bieli/IoText-data-protocol/pull/5 Thx @ksyuzi
So it looks like there are 2 dataclasses defined with exactly the same name Item
, one resides in types/item.py
and second one is inside of types/item_type.py
and both are exactly the same. Implementation of the library in src uses former, where tests uses the latter. This causes the error at the very beginning because instances are of a different classes.
@ksyuzi
@przemek1236 thank you, but the explanation wasn't necessary, I figured it out and committed this fix. @bieli both tests now pass, so no need for the TODO. please, take a look.
Great contribution ;-)
I merged solution today and propose next bug fixes here #12 (+ code coverage)
Unit test skipped - to fixing - is here