biemond / biemond-oradb

Puppet Oracle Database Module
Apache License 2.0
59 stars 113 forks source link

timeout parameter #237

Open pmpetit opened 6 years ago

pmpetit commented 6 years ago

Hello, Do you think we could add a parameter timeout, to change "timeout => 0" value

exec { "oracle database ${title}":
  command     => $command,
  creates     => "${oracle_base}/admin/${db_name}",
  timeout     => 0,
  path        => $exec_path,
  user        => 'root',
  group       => 'root',
  cwd         => $oracle_base,
  environment => ["USER=${user}",],
  logoutput   => true,

}

to prevent infinite waiting for puppet agent, that can impact some other configuration ?

I will do it and propose a Pull Request

Thanks

biemond commented 6 years ago

Hi,

Is this code for a db based on a dbt template because that 1 can take ages. And maybe we should make it a parameter with 0 as default value which you can override.

Thanks