biemond / biemond-oradb

Puppet Oracle Database Module
Apache License 2.0
59 stars 113 forks source link

Support systemd on any Enterprise Linux version greater than or equal to 7 #288

Closed DLeich closed 2 years ago

DLeich commented 2 years ago

Currently, the installasm class only creates a systemd unit file on EL 7. This should support 7 and greater.

I could further clean this up by utilizing the puppet-systemd module to create the unit file and enable the service:

`$ohasd_systemd_ensure = $facts['systemd'] ? { true => 'present', default => 'absent', }

systemd::unit_file { 'oracle-ohasd': ensure => $ohasd_systemd_ensure, source => epp('oradb/ohas.service.epp'), enable => true, active => true, require => Exec["install oracle grid ${title}"], }`

If you agree with further cleaning up and using the systemd forge module, I'll add an additional commit replacing it.

DLeich commented 2 years ago

@biemond - any thoughts on the proposed changes in this PR? Would you prefer to do this as coded in this PR using puppet native types, or would it be fine to add a dependency for the systemd module, as proposed in the above comment?

biemond commented 2 years ago

thanks