biemond / biemond-oradb

Puppet Oracle Database Module
Apache License 2.0
59 stars 113 forks source link

Add tnsnames.ora parameters #297

Closed bschonec closed 1 year ago

bschonec commented 1 year ago

I've added the following parameters to the tnsnames.ora file:

CONNECT_TIMEOUT TRANSPORT_CONNECT_TIMEOUT RETRY_COUNT

In addition, I've simplified the default PROTOCOL logic and consolidated the load balanced logic into a single loop.

bschonec commented 1 year ago

Unfortunately, I haven't figured out how to properly indent the tnsnames.ora entries properly so there are some very slight formatting differences that do not affect the functionality of the file. I suggest that you create a testing branch or a beta branch and not merge these changes into the main/master branch yet.

I'm just beginning my journey with Puppet spec tests so I'll submit some very basic tests soon.